Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop dependency on delay #383

Merged
merged 3 commits into from
Oct 23, 2018
Merged

refactor: drop dependency on delay #383

merged 3 commits into from
Oct 23, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2018
@ghost ghost assigned JustinBeckwith Oct 21, 2018
@codecov
Copy link

codecov bot commented Oct 22, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@cc50973). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #383   +/-   ##
=========================================
  Coverage          ?   99.54%           
=========================================
  Files             ?       12           
  Lines             ?     1323           
  Branches          ?        0           
=========================================
  Hits              ?     1317           
  Misses            ?        6           
  Partials          ?        0
Impacted Files Coverage Δ
src/session-pool.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc50973...bae8a58. Read the comment docs.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2018
@JustinBeckwith JustinBeckwith requested a review from jkwlui October 23, 2018 02:00
@JustinBeckwith JustinBeckwith merged commit bb6a7c0 into googleapis:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwlui jkwlui jkwlui approved these changes

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

Assignees

@JustinBeckwith JustinBeckwith

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustinBeckwith @jkwlui @googlebot @kokoro-team