Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GCLOUD_PROJECT to circle config for system tests #329

Closed
wants to merge 1 commit into from
Closed

add GCLOUD_PROJECT to circle config for system tests #329

wants to merge 1 commit into from

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Sep 17, 2018

Should fix #190

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2018
@ghost ghost assigned jkwlui Sep 17, 2018
JustinBeckwith
JustinBeckwith reviewed Sep 17, 2018
View reviewed changes
.circleci/config.yml
@@ -159,6 +159,7 @@ jobs:
command: npm run system-test
environment:
GOOGLE_APPLICATION_CREDENTIALS: .circleci/key.json
GCLOUD_PROJECT: long-door-651

This comment was marked as spam.

Sign in to view

@jkwlui
Copy link
Member Author

jkwlui commented Sep 17, 2018

GCLOUD_PROJECT is configured for system-tests in synthtool templates.

nodejs-spanner's synth.py is not configured to pull templates yet, only generate library - I'm going to modify synth.py in a later PR :)

@jkwlui
Copy link
Member Author

jkwlui commented Sep 17, 2018

Merging this first to see if system-test passes

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2018
@jkwlui
Copy link
Member Author

jkwlui commented Sep 17, 2018

also kokoro is not properly configured here yet

@jkwlui
Copy link
Member Author

jkwlui commented Sep 17, 2018

Closing in favour of #330

@jkwlui jkwlui closed this Sep 17, 2018
@jkwlui jkwlui deleted the add-gcloud-project-to-system-test branch September 17, 2018 19:48
@sduskis sduskis removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith left review comments

Assignees

@JustinBeckwith JustinBeckwith

@jkwlui jkwlui

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nightly testing flakyness
4 participants
@jkwlui @JustinBeckwith @sduskis @googlebot