Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pin version for nodejs gax-node #1617

Merged
merged 3 commits into from
Apr 25, 2022
Merged

fix: pin version for nodejs gax-node #1617

merged 3 commits into from
Apr 25, 2022

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta requested review from a team as code owners April 19, 2022 15:19
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Apr 19, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2022
@asthamohta asthamohta requested a review from bcoe April 20, 2022 05:12
@bcoe bcoe changed the title fix: fixing version for nodejs gax-node fix: pin version for nodejs gax-node Apr 25, 2022
@bcoe bcoe merged commit fb0017f into googleapis:main Apr 25, 2022
@release-please release-please bot mentioned this pull request Apr 25, 2022
Closed
@bcoe
Copy link
Contributor

bcoe commented Apr 25, 2022

@asthamohta can we open a tracking issue to try to correct this version incompatibility.

@duncanfinney
Copy link

@bcoe @asthamohta Was the downgrade from ^2.29.3 to ^2.3.0 purposeful, or is it a typo that is supposed to be an upgrade to ^2.30.0?

We are seeing some memory leaks in google-gax --> @grpc/grpc-js that we have a hunch are fixed with the newer version from reading some other github tickets.

@release-please release-please bot mentioned this pull request May 30, 2022
Merged
asthamohta added a commit to asthamohta/nodejs-spanner that referenced this pull request Jun 20, 2022
@asthamohta
fix: pin version for nodejs gax-node (googleapis#1617)
71697ac
@21m57 21m57 mentioned this pull request Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asthamohta @bcoe @duncanfinney