Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor create database options schema to accept array #1578

Merged
merged 3 commits into from
Mar 8, 2022
Merged

feat: Refactor create database options schema to accept array #1578

merged 3 commits into from
Mar 8, 2022

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta requested review from a team as code owners February 24, 2022 12:27
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Feb 24, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2022
@asthamohta asthamohta linked an issue Feb 24, 2022 that may be closed by this pull request
schema field in CreateDatabaseOptions does not allow string[]. #1575
Closed
@asthamohta asthamohta requested a review from olavloite February 24, 2022 20:37
vi3k6i5
vi3k6i5 approved these changes Feb 25, 2022
View reviewed changes
Copy link

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asthamohta
Copy link
Contributor Author

Hi @winor30 Could you update the branch and I will merge it

@winor30
Copy link
Contributor

winor30 commented Mar 7, 2022

@asthamohta

#1578 (comment)

PR updates have been completed.

@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2022
@asthamohta asthamohta merged commit b1c88ac into googleapis:main Mar 8, 2022
@asthamohta
Copy link
Contributor Author

@winor30 the change will be available in the next release. Thanks a ton!

@winor30 winor30 deleted the refactor-create-database-options-schema branch March 8, 2022 06:08
@release-please release-please bot mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@vi3k6i5 vi3k6i5 vi3k6i5 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema field in CreateDatabaseOptions does not allow string[].
4 participants
@asthamohta @winor30 @olavloite @vi3k6i5