feat: add gcp client attributes for Opentelemetry traces

googleapis · Jan 10, 2025 · 3577804 · 3577804
1 parent 8d89b9a
commit 3577804
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/observability-test/observability.ts b/observability-test/observability.ts
@@ -142,6 +142,24 @@ describe('startTrace', () => {
         'Missing OTEL_SCOPE_VERSION attribute'
       );
 
+      assert.equal(
+        span.attributes['gcp.client.service'],
+        'Spanner',
+        'Missing gcp.client.service attribute'
+      );
+
+      assert.equal(
+        span.attributes['gcp.client.version'],
+        TRACER_VERSION,
+        'Missing gcp.client.version attribute'
+      );
+
+      assert.equal(
+        span.attributes['gcp.client.repo'],
+        'googleapis/nodejs-spanner',
+        'Missing gcp.client.repo attribute'
+      );
+
       assert.equal(
         span.attributes[SEMATTRS_DB_SYSTEM],
         'spanner',

diff --git a/src/instrument.ts b/src/instrument.ts
@@ -153,6 +153,9 @@ export function startTrace<T>(
       span.setAttribute(SEMATTRS_DB_SYSTEM, 'spanner');
       span.setAttribute(ATTR_OTEL_SCOPE_NAME, TRACER_NAME);
       span.setAttribute(ATTR_OTEL_SCOPE_VERSION, TRACER_VERSION);
+      span.setAttribute('gcp.client.service', 'Spanner');
+      span.setAttribute('gcp.client.version', TRACER_VERSION);
+      span.setAttribute('gcp.client.repo', 'googleapis/nodejs-spanner');
 
       if (config.tableName) {
         span.setAttribute(SEMATTRS_DB_SQL_TABLE, config.tableName);