-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample: add samples for dead letter topics #1010
Conversation
@laljikanjareeya Thanks so much for adding these! It looks like the CI is acting up. Let me try another re-run. |
Ah, this is holding it up. #1009 |
@laljikanjareeya Looks like there's one actual error in the sample test:
Oh, a typo in the title of the test too. Thanks GitHub :) Otherwise this looks pretty good to me. |
Codecov Report
@@ Coverage Diff @@
## master #1010 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 22 22
Lines 10615 10615
Branches 509 466 -43
=======================================
Hits 10107 10107
Misses 505 505
Partials 3 3 Continue to review full report at Codecov.
|
Thanks @feywind for the review I fix the given changes. |
Fixes #947