Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenTelemetry Support #1061

Closed
sethmaxwl opened this issue Jul 17, 2020 · 4 comments · Fixed by #1078
Closed

Add OpenTelemetry Support #1061

sethmaxwl opened this issue Jul 17, 2020 · 4 comments · Fixed by #1078
Assignees
@sethmaxwl
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@sethmaxwl
Copy link
Contributor

OpenTelemetry should be added to PubSub to provide OpenTracing and OpenCensus functionality as one API and SDK. It would be helpful to use it to trace a message throughout its life cycle. This is being added to the Python Pub/Sub client and would be useful to have in the node client as well.

googleapis/python-pubsub#149
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jul 17, 2020
@meredithslota meredithslota added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 17, 2020
@feywind
Copy link
Collaborator

feywind commented Jul 21, 2020

@sethmaxwl You're working on this, right? Just trying to get it assigned to the right person.

@sethmaxwl
Copy link
Contributor Author

@feywind Yes I am.

@thespacedeck thespacedeck mentioned this issue Jul 22, 2020
Closed
@thespacedeck
Copy link

I cannot wait for this feature :) Thanks for working on this! It would be great to even pass through your own custom HTTP headers, from where you can set the traceparent property in order to propgate it manually. We're currently doing this with Cloud Tasks and it works great.

@sethmaxwl sethmaxwl mentioned this issue Aug 7, 2020
Merged
@CyberHippo
Copy link

Hi,

Thanks for all the good work on supporting OpenTelemetry!

Is the tracing limited to the use of BasicTracerProvider and ConsoleSpanExporter or is it compatible with other tracers/exporters such as the NodeTracerProvider tracer or the CollectorTraceExporter exporter ?

feywind pushed a commit to feywind/nodejs-pubsub that referenced this issue Nov 12, 2024
@gcf-owl-bot
feat: AuditConfig for IAM v1 (googleapis#1061)
d1b5f1a 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 439356405

Source-Link: googleapis/googleapis@afa2ba1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/3e40c17e1510c95fab58fc2143ccb61cceca5989
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2U0MGMxN2UxNTEwYzk1ZmFiNThmYzIxNDNjY2I2MWNjZWNhNTk4OSJ9

docs: Update `cpu_utilization_percent` limit
docs: Remove the limitation of all clusters in a CMEK instance must use the same key

PiperOrigin-RevId: 438385300

Source-Link: googleapis/googleapis@c59f02e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/04d03d17aafa7b4422f73c93600f040542817fcd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDRkMDNkMTdhYWZhN2I0NDIyZjczYzkzNjAwZjA0MDU0MjgxN2ZjZCJ9
feywind pushed a commit to feywind/nodejs-pubsub that referenced this issue Nov 12, 2024
@release-please
chore(main): release 3.10.0 (googleapis#1058)
3a02e49 
🤖 I have created a release *beep* *boop*
---


## [3.10.0](googleapis/nodejs-bigtable@v3.9.4...v3.10.0) (2022-04-06)


### Features

* Add ListHotTablets API method and protobufs ([googleapis#1057](googleapis/nodejs-bigtable#1057)) ([2b175ac](googleapis/nodejs-bigtable@2b175ac))
* AuditConfig for IAM v1 ([googleapis#1061](googleapis/nodejs-bigtable#1061)) ([d1b5f1a](googleapis/nodejs-bigtable@d1b5f1a))
* enable channel pooling ([googleapis#1065](googleapis/nodejs-bigtable#1065)) ([6c3c397](googleapis/nodejs-bigtable@6c3c397))


### Bug Fixes

* disable retry-request, add exponential backoff in mutateRows and readRows ([googleapis#1060](googleapis/nodejs-bigtable#1060)) ([3718011](googleapis/nodejs-bigtable@3718011))
* retry rst_stream errors ([googleapis#1059](googleapis/nodejs-bigtable#1059)) ([90de80f](googleapis/nodejs-bigtable@90de80f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sethmaxwl sethmaxwl

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Opentelemetry integration sethmaxwl/nodejs-pubsub
5 participants
@meredithslota @CyberHippo @sethmaxwl @feywind @thespacedeck