fix: prevent crashes if an inactive stream receives an error. (#2283)

googleapis · Jan 21, 2025 · f58fe79 · f58fe79
1 parent a2950e0
commit f58fe79
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/dev/src/watch.ts b/dev/src/watch.ts
@@ -495,6 +495,12 @@ abstract class Watch<
                 'Closing inactive stream'
               );
               backendStream.emit('end');
+              backendStream.on('error', () => {
+                // Note that emitting 'end' above does not prevent the Duplex
+                // from receiving potential errors from the backend. Since the
+                // stream is no longer active (`isActive` is false), we
+                // swallow / ignore any errors it may receive.
+              });
               return;
             }
             logger('Watch.initStream', this.requestTag, 'Opened new stream');