Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Convert to TypeScript #97

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Convert to TypeScript #97

merged 2 commits into from
Sep 6, 2018

Conversation

JustinBeckwith
Copy link
Contributor

BREAKING CHANGE: This module now supports es module style imports. This provides forward compatibility with TypeScript, Babel, and the new es module spec.

Old code

const DNS = require('@google-cloud/dns');
const dns = new DNS();
// OR...
const dns = require('@google-cloud/dns')();

New code

const {DNS} = require('@google-cloud/dns');
const dns = new DNS();

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2018
@ghost ghost assigned JustinBeckwith Sep 6, 2018
@JustinBeckwith JustinBeckwith requested review from fhinkel, jkwlui, alexander-fenster and a team and removed request for alexander-fenster September 6, 2018 03:02
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp

@JustinBeckwith JustinBeckwith merged commit 3eb3de6 into googleapis:master Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants