Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(key): copy Datastore#key examples to Key ctor #306

Merged
merged 1 commit into from
Jan 21, 2019
Merged

docs(key): copy Datastore#key examples to Key ctor #306

merged 1 commit into from
Jan 21, 2019

Conversation

callmehiphop
Copy link
Contributor

Fixes #295

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

It seems like the natural way to see Key creation examples is to go to the API docs and click on the Key constructor. The Datastore#key method is kind of buried and contains more complete examples. This is just a copypasta from the method to the constructor.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2019
@callmehiphop callmehiphop added the type: docs Improvement to the documentation for an API. label Jan 21, 2019
@callmehiphop callmehiphop merged commit 4cd6019 into googleapis:master Jan 21, 2019
@callmehiphop callmehiphop deleted the dg--295 branch January 21, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@callmehiphop @JustinBeckwith @googlebot