Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: start converting to es classes #173

Merged
merged 1 commit into from
Aug 20, 2018
Merged

chore: start converting to es classes #173

merged 1 commit into from
Aug 20, 2018

Conversation

JustinBeckwith
Copy link
Contributor

@callmehiphop @stephenplusplus The system tests on master seem to fail for me (and this PR), but are passing in CI scratches head. Can y'all try running the system tests against this branch?

There are actually very few changes in here, sorry the GH diff is so bad.

@ghost ghost assigned JustinBeckwith Aug 18, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2018
@codecov
Copy link

codecov bot commented Aug 18, 2018

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #173   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         646    616   -30     
=====================================
- Hits          646    616   -30
Impacted Files Coverage Δ
src/query.js 100% <100%> (ø) ⬆️
src/request.js 100% <100%> (ø) ⬆️
src/transaction.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9965e47...1e70099. Read the comment docs.

@stephenplusplus
Copy link
Contributor

Both master and this PR's system tests pass for me. Were you getting errors locally from this branch's system tests? What were they?

@JustinBeckwith JustinBeckwith merged commit 8013a8f into googleapis:master Aug 20, 2018
@JustinBeckwith
Copy link
Contributor Author

image

Tons of strictEqual errors:

Uncaught AssertionError [ERR_ASSERTION]: Input A expected to strictly deep-equal input B:

Which in retrospect, is probably my fault. But I'm weirded out that nobody else is seeing them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants