Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent error when decode: false option is set in createReadStream. #403

Merged
merged 8 commits into from
Jan 30, 2019
Merged

fix: Prevent error when decode: false option is set in createReadStream. #403

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ea5b129
prevent error from propogating when `decode: false` option is set in …
zrosenbauer Jan 20, 2019
96a6872
fix logic
zrosenbauer Jan 20, 2019
4b91b90
still allow comparison
zrosenbauer Jan 21, 2019
381f947
add guardrails in case row.key is nil
zrosenbauer Jan 21, 2019
69c7f56
Merge branch 'master' into bugfix/createreadstream-error
JustinBeckwith Jan 24, 2019
05b2c95
Merge branch 'master' into bugfix/createreadstream-error
JustinBeckwith Jan 26, 2019
26d4863
Merge branch 'master' into bugfix/createreadstream-error
JustinBeckwith Jan 30, 2019
04c93f1
Update chunktransformer.js
JustinBeckwith Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/chunktransformer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,12 @@ class ChunkTransformer extends Transform {
const newRowKey = Mutation.convertFromBytes(chunk.rowKey, {
userOptions: this.options,
});
const oldRowKey = row.key || '';
if (
newRowKey &&
chunk.rowKey &&
newRowKey.length !== 0 &&
newRowKey !== row.key
newRowKey.toString() !== oldRowKey.toString()
) {
this.destroy(
new TransformError({
Expand Down