Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the system test. #251

Closed
wants to merge 2 commits into from
Closed

Fixing the system test. #251

wants to merge 2 commits into from

Conversation

sduskis
Copy link
Contributor

@sduskis sduskis commented Jul 18, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2018
@ghost ghost assigned sduskis Jul 18, 2018
@sduskis sduskis requested a review from stephenplusplus July 18, 2018 20:30
@codecov
Copy link

codecov bot commented Jul 18, 2018 •
edited
Loading

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #251   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines        1266   1266           
=====================================
  Hits         1266   1266

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a292b54...d951e7d. Read the comment docs.

stephenplusplus
stephenplusplus suggested changes Jul 19, 2018
View reviewed changes
system-test/bigtable.js
assert.strictEqual(maxAge.seconds, rule.age.seconds);
assert.strictEqual(maxAge.nanas, rule.age.nanas);
assert.strictEqual(maxAge.seconds, rule.age.seconds.toString());
assert.strictEqual(maxAge.nanos, rule.age.nanos.toString());

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@sduskis sduskis closed this Jul 23, 2018
@sduskis sduskis mentioned this pull request Jul 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus requested changes

Assignees

@sduskis sduskis

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sduskis @stephenplusplus @googlebot