Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop node4 completely #160

Merged
merged 9 commits into from
Jun 1, 2018
Merged

Drop node4 completely #160

merged 9 commits into from
Jun 1, 2018

Conversation

kolodny
Copy link
Contributor

@kolodny kolodny commented Jun 1, 2018

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@ghost ghost assigned kolodny Jun 1, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@codecov
Copy link

codecov bot commented Jun 1, 2018 •
edited
Loading

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #160   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines        1357   1357           
=====================================
  Hits         1357   1357

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d987d1...2dd343b. Read the comment docs.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 1, 2018
@kolodny kolodny merged commit 5a477e7 into googleapis:master Jun 1, 2018
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
@kolodny kolodny deleted the really-drop-node4 branch June 1, 2018 19:59
@sduskis sduskis mentioned this pull request Jun 1, 2018
Closed
@stephenplusplus stephenplusplus mentioned this pull request Jun 28, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees

@kolodny kolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolodny @googlebot @JustinBeckwith