Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to latest generator with fix for regex bug #1000

Merged
merged 5 commits into from
Feb 1, 2022

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Jan 31, 2022

BEGIN_COMMIT_OVERRIDE
feat: add explicit routing header annotations for bigtable/v2
feat: add routing_proto to the Bazel dependencies for bigtable/v2
END_COMMIT_OVERRIDE

  • Regenerate this pull request now.

Committer: @summer-ji-eng
PiperOrigin-RevId: 424935187

Source-Link: googleapis/googleapis@687f5ed

Source-Link: https://github.com/googleapis/googleapis-gen/commit/49af052a22d4d14116350470f4e1d7b7e61152f6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzkyNjk5YzZhOGM5MzlhNmViMTNkMjRlNDQ0YjAxZTVmMzBjOTAzNCJ9

Fix new build on latest proto change with routing annotation. Issue PR

Updates to prepare the fix:
gapic-generator-typescript update to 2.12.2
gax-nodejs update to 2.29.5
DockerFile in synthtool update to 2.29.5

Changes in this PR:

  1. Latest generated code in src/v2/...
  2. Linter fix in handwritten layer, src/index
  3. package.json update npm prepare and update gax version.

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Jan 31, 2022
@summer-ji-eng summer-ji-eng marked this pull request as draft January 31, 2022 23:52
@summer-ji-eng summer-ji-eng force-pushed the update_latest_generator branch 2 times, most recently from d7a7897 to 0459155 Compare February 1, 2022 19:01
@summer-ji-eng summer-ji-eng requested a review from bcoe February 1, 2022 19:04
@summer-ji-eng summer-ji-eng marked this pull request as ready for review February 1, 2022 19:04
@gcf-owl-bot
Copy link
Contributor

gcf-owl-bot bot commented Feb 1, 2022

Owl bot is regenerating pull request 1000...
Build name: NDg1MjRmY2QtY2MwZS00ZjhkLTkwZWYtOWRlZjU4ZGUzZTdk

@gcf-owl-bot gcf-owl-bot bot force-pushed the update_latest_generator branch from 8e9f4e3 to 883c08b Compare February 1, 2022 19:07
@snippet-bot
Copy link

snippet-bot bot commented Feb 1, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gcf-owl-bot
Copy link
Contributor

gcf-owl-bot bot commented Feb 1, 2022

Owl bot is regenerating pull request 1000...
Build name: MzYwODI1ODYtNzU0MS00MDE5LWEzMjMtNWMzYWEzZWZkN2Nk

@gcf-owl-bot gcf-owl-bot bot force-pushed the update_latest_generator branch from 883c08b to e4b9b06 Compare February 1, 2022 19:26
@summer-ji-eng summer-ji-eng force-pushed the update_latest_generator branch from e4b9b06 to 0459155 Compare February 1, 2022 19:51
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2022
@bcoe bcoe changed the title fix: build fails on latest generator build: update generator to latest version Feb 1, 2022
@bcoe bcoe changed the title build: update generator to latest version fix: update generator to latest version with fixes four routing regex Feb 1, 2022
@bcoe bcoe changed the title fix: update generator to latest version with fixes four routing regex fix: update to latest generator with fix for regex bug Feb 1, 2022
@bcoe bcoe merged commit 6a26c07 into main Feb 1, 2022
@bcoe bcoe deleted the update_latest_generator branch February 1, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants