Skip to content

Commit

Permalink
fix: Fix flakey test by extending timeout (#1350)
Browse files Browse the repository at this point in the history
* fix: Fix flakey test by extending timeout

Add timeout to the read syncronously test as it is blocking a few tests from being merged.

* Increase the timeout to unblock the CI pipeline

Tests are failing for non-windows cases due to timeouts. Add this line of code for timeouts.

* run linter
  • Loading branch information
danieljbruce authored Oct 5, 2023
1 parent 04517a5 commit 906ac79
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 2 additions & 3 deletions system-test/bigtable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,8 @@ describe('Bigtable', () => {

it('should test Iam permissions for the instance', async () => {
const permissions = ['bigtable.tables.get', 'bigtable.tables.readRows'];
const [grantedPermissions] = await INSTANCE.testIamPermissions(
permissions
);
const [grantedPermissions] =
await INSTANCE.testIamPermissions(permissions);
assert.strictEqual(grantedPermissions.length, permissions.length);
permissions.forEach(permission => {
assert.strictEqual(grantedPermissions.includes(permission), true);
Expand Down
4 changes: 3 additions & 1 deletion test/readrows.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ describe('Bigtable/ReadRows', () => {
service = new BigtableClientMockService(server);
});

it('should create read stream and read synchronously', done => {
it('should create read stream and read synchronously', function (done) {
this.timeout(60000);

// 1000 rows must be enough to reproduce issues with losing the data and to create backpressure
const keyFrom = 0;
const keyTo = 1000;
Expand Down

0 comments on commit 906ac79

Please sign in to comment.