Skip to content

Commit

Permalink
fix: Sample rowkey generic header conformance test (#1550)
Browse files Browse the repository at this point in the history
Grab app profiled id from client to fix conformance test
  • Loading branch information
kevkim-codes authored Dec 17, 2024
1 parent f6176c1 commit 6ef7671
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion testproxy/known_failures.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,5 @@ TestReadRows_Retry_WithRetryInfo_MultipleErrorResponse\|
TestCheckAndMutateRow_NoRetry_TransientError\|
TestCheckAndMutateRow_Generic_DeadlineExceeded\|
TestCheckAndMutateRow_Generic_Headers\|
TestSampleRowKeys_Generic_Headers\|
TestSampleRowKeys_Generic_DeadlineExceeded\|
TestSampleRowKeys_Retry_WithRoutingCookie
5 changes: 3 additions & 2 deletions testproxy/services/sample-row-keys.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ const sampleRowKeys = ({clientMap}) =>
normalizeCallback(async rawRequest => {
const {request} = rawRequest;
const {request: sampleRowKeysRequest} = request;
const {appProfileId, tableName} = sampleRowKeysRequest;

const {tableName} = sampleRowKeysRequest;
const {clientId} = request;

const appProfileId = clientMap.get(clientId).appProfileId;
const client = clientMap.get(clientId)[v2];
const samples = await new Promise((res, rej) => {
const response = [];
Expand Down

0 comments on commit 6ef7671

Please sign in to comment.