-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vector store class structure #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averikitsch
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment before merging
Integration tests will only pass after merging PR to create the vector store table: #4 |
dishaprakash
pushed a commit
that referenced
this pull request
Nov 27, 2024
dishaprakash
added a commit
that referenced
this pull request
Nov 27, 2024
* feat: Adding init index store table methods to Engine * Added docstring * Made review changes * Made review changes * feat: Add init methods to engine class for the Vector Store (#4) * feat: Add init methods to engine class for the Vector Store * fix: false stores_text creates nullable text column --------- Co-authored-by: Averi Kitsch <akitsch@google.com> * feat: vector store class structure (#1) * feat: Adding init index store table methods to Engine * Made review changes * Rebase * Rebase * Minor fix * Linter fix --------- Co-authored-by: Vishwaraj Anand <vishwarajanand@google.com> Co-authored-by: Averi Kitsch <akitsch@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds vector store class structure for implementing the instance methods.
Review pointers:
(Now removed) Note:perform_validation
is an optional flag added only to be removed in following PRs. Its purpose is only to help split the PRs and is marked withTODO
to be removed.PyTest log
Log for pytest command
PYTHONPATH=src pytest -s tests/test_async_vectorstore.py