Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vector store class structure #1

Merged
merged 14 commits into from
Nov 26, 2024
Merged

Conversation

vishwarajanand
Copy link
Collaborator

@vishwarajanand vishwarajanand commented Nov 25, 2024

Adds vector store class structure for implementing the instance methods.

Review pointers:

  • Class structure, method naming
  • Exceptions, doc blocks, comments
  • Tests for failure scenarios

(Now removed) Note: perform_validation is an optional flag added only to be removed in following PRs. Its purpose is only to help split the PRs and is marked with TODO to be removed.

PyTest log

Log for pytest command

PYTHONPATH=src pytest -s tests/test_async_vectorstore.py

(base) ➜  llama-index-alloydb-pg-python git:(vs_implementation) ✗ PYTHONPATH=src pytest -s tests/test_async_vectorstore.py                 
/usr/local/google/home/vishwarajanand/miniconda3/lib/python3.11/site-packages/pytest_asyncio/plugin.py:208: PytestDeprecationWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset.
The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous fixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "class", "module", "package", "session"

  warnings.warn(PytestDeprecationWarning(_DEFAULT_FIXTURE_LOOP_SCOPE_UNSET))
===================================================================================================================================== test session starts =====================================================================================================================================
platform linux -- Python 3.11.4, pytest-8.3.2, pluggy-1.5.0
rootdir: /usr/local/google/home/vishwarajanand/github/llama-index-alloydb-pg-python
configfile: pyproject.toml
plugins: asyncio-0.24.0, anyio-4.4.0
asyncio: mode=Mode.STRICT, default_loop_scope=None
collected 13 items                                                                                                                                                                                                                                                                            

tests/test_async_vectorstore.py .............

===================================================================================================================================== 13 passed in 17.13s =====================================================================================================================================
(base) ➜  llama-index-alloydb-pg-python git:(vs_implementation) ✗

@vishwarajanand vishwarajanand marked this pull request as ready for review November 25, 2024 07:54
Copy link
Collaborator

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment before merging

src/llama_index_alloydb_pg/async_vectorstore.py Outdated Show resolved Hide resolved
@averikitsch averikitsch requested a review from a team as a code owner November 25, 2024 20:20
@vishwarajanand
Copy link
Collaborator Author

Integration tests will only pass after merging PR to create the vector store table: #4

@vishwarajanand vishwarajanand merged commit 27cfe3d into main Nov 26, 2024
7 checks passed
@vishwarajanand vishwarajanand deleted the vs_implementation branch November 26, 2024 17:06
dishaprakash pushed a commit that referenced this pull request Nov 27, 2024
dishaprakash added a commit that referenced this pull request Nov 27, 2024
* feat: Adding init index store table methods to Engine

* Added docstring

* Made review changes

* Made review changes

* feat: Add init methods to engine class for the Vector Store (#4)

* feat: Add init methods to engine class for the Vector Store

* fix: false stores_text creates nullable text column

---------

Co-authored-by: Averi Kitsch <akitsch@google.com>

* feat: vector store class structure (#1)

* feat: Adding init index store table methods to Engine

* Made review changes

* Rebase

* Rebase

* Minor fix

* Linter fix

---------

Co-authored-by: Vishwaraj Anand <vishwarajanand@google.com>
Co-authored-by: Averi Kitsch <akitsch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants