fix: Review session updates #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWhitehead
requested changes
Apr 4, 2023
...d-storage/src/main/java/com/google/cloud/storage/transfermanager/ParallelDownloadConfig.java
Outdated
Show resolved
Hide resolved
...ud-storage/src/main/java/com/google/cloud/storage/transfermanager/TransferManagerConfig.java
Show resolved
Hide resolved
...ud-storage/src/main/java/com/google/cloud/storage/transfermanager/TransferManagerConfig.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/transfermanager/UploadCallable.java
Outdated
Show resolved
Hide resolved
Comment on lines
+54
to
60
| /** | ||
| * A common prefix that is applied to downloaded objects before they are written to the | ||
| * filesystem. | ||
| */ | ||
| public @NonNull String getPrefix() { | ||
| return prefix; | ||
| } |
There was a problem hiding this comment.
This isn't currently being used but DownloadCallable.
Instead of prefix what if we change this to baseDirectory or downloadDirectory and instead of String we use Path. That way, when download job is creating files it can resolved them from this directory AND validate the output path of the object after resolution is still below the output path.
What do you think?
We don't have to make this change in this PR, doing it in a follow up would be better.
There was a problem hiding this comment.
I am onboard with that change. I will update in a followup.
…ansfermanager/ParallelDownloadConfig.java Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
…ansfermanager/TransferManagerConfig.java Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead
approved these changes
Apr 5, 2023
gcf-owl-bot bot
added a commit
that referenced
this pull request
May 9, 2024
* chore: update dependency versions in java templates * update other templates Source-Link: googleapis/synthtool@0b86c72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:68ba5f5164a4b55529d358bb262feaa000536a0c62980727dd05a91bbb47ea5e
sydney-munro
pushed a commit
that referenced
this pull request
May 21, 2024
* chore: update dependency versions in java templates * update other templates Source-Link: googleapis/synthtool@0b86c72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:68ba5f5164a4b55529d358bb262feaa000536a0c62980727dd05a91bbb47ea5e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from review session with @BenWhitehead
Summary of changes: