Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update ci.yaml to introduce Java 21 unit testing (#1907) #1305

Merged
merged 26 commits into from
Dec 12, 2023
Merged

ci: Update ci.yaml to introduce Java 21 unit testing (#1907) #1305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f489326
ci: Update ci.yaml to introduce Java 21 unit testing (#1907)
gcf-owl-bot[bot] Dec 1, 2023
cfd1880
chore: set up Units (21)
ddixit14 Dec 11, 2023
6a22fd8
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 11, 2023
2e91b20
Update pom.xml
ddixit14 Dec 11, 2023
f708418
Update pom.xml to include bytebuddy
ddixit14 Dec 11, 2023
ed4a17e
Update pom.xml to make bytebuddy version latest
ddixit14 Dec 11, 2023
6f94415
Update pom.xml
ddixit14 Dec 11, 2023
50f70a8
Update pom.xml to include test scope.
ddixit14 Dec 11, 2023
decbc2d
chore: make the plugin ignore this dependency.
ddixit14 Dec 11, 2023
cb51e63
remove bytebuddy scope
ddixit14 Dec 12, 2023
64ee214
remove plugin config
ddixit14 Dec 12, 2023
6fae7d5
remove bytebuddy from this module
ddixit14 Dec 12, 2023
4837ed2
exclude byte-buddy from being pulled in as a transitive depedency.
ddixit14 Dec 12, 2023
520aee7
Update pom.xml to add bytebuddy 1.12.21
ddixit14 Dec 12, 2023
3f760d4
bytebuddy scope = test
ddixit14 Dec 12, 2023
bc0ec5d
remove whitespaces
ddixit14 Dec 12, 2023
35f8dc9
line remove
ddixit14 Dec 12, 2023
5abc456
add byte-buddy-agent dependency
ddixit14 Dec 12, 2023
b6cea02
adding bytebuddy flag
ddixit14 Dec 12, 2023
3f6b599
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 12, 2023
137d92f
add -Dnet.bytebuddy.experimental=true
ddixit14 Dec 12, 2023
ac02616
remove explicit dependency declaration
ddixit14 Dec 12, 2023
bbdda13
remove unnecessary spaces
ddixit14 Dec 12, 2023
4e0e637
no changes in pom.xml
ddixit14 Dec 12, 2023
2277123
Update pom.xml
ddixit14 Dec 12, 2023
448491e
adding comments.
ddixit14 Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/.OwlBot.lock.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
# limitations under the License.
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-java:latest
digest: sha256:bc2bf47c7370f1b1a8a46b0c104ce7e43644ac58902c9de265fe1f253fcc2506
# created: 2023-10-31T13:44:21.909247346Z
digest: sha256:6f431774e11cc46619cf093fd1481193c4024031073697fa18f0099b943aab88
# created: 2023-12-01T19:50:20.444857406Z
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [11, 17]
java: [11, 17, 21]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
Expand Down
3 changes: 2 additions & 1 deletion .kokoro/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ case ${JOB_TYPE} in
test)
echo "SUREFIRE_JVM_OPT: ${SUREFIRE_JVM_OPT}"
retry_with_backoff 3 10 \
mvn test -B -ntp -Dclirr.skip=true -Denforcer.skip=true ${SUREFIRE_JVM_OPT}
# adding -Dnet.bytebuddy.experimental=true to enable Java 21 testing
mvn test -B -ntp -Dclirr.skip=true -Denforcer.skip=true ${SUREFIRE_JVM_OPT} -Dnet.bytebuddy.experimental=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Can you add source code comment about this option was for Java 21?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

RETURN_CODE=$?
;;
lint)
Expand Down