-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FileSystemProvider::readAttributes faked posix support #1067
Conversation
6c5a033
to
7caf72d
Compare
7caf72d
to
d9d1397
Compare
Thanks for opening this PR! I'm reaching out to some teammates to get their input on any gotchas when emulating posix over a gcs bucket. |
Yes. So I my view the worst that can happen is that the expected operation fails because the returned fake permission attributes were incorrect (i.e. not allowed to read/write). |
1282ba0
to
d5d82b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folks I reached out to didn't have any objections to the approach taken hear.
Thanks for the contribution!
🤖 I have created a release *beep* *boop* --- ## [0.126.0](https://togithub.com/googleapis/java-storage-nio/compare/v0.125.0...v0.126.0) (2022-12-09) ### Features * FileSystemProvider::readAttributes faked posix support ([#1067](https://togithub.com/googleapis/java-storage-nio/issues/1067)) ([b813ccc](https://togithub.com/googleapis/java-storage-nio/commit/b813ccc87ecff40f56fccf2ce981f16422c190f1)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
This is the follow up patch after #1066 to add fake posix support in FileSystemProvider::readAttributes.
Important to note is that the values returned in this patch are all fixed and fake.
The main goal of this patch is to have minimal support for the posix attributes because some existing libraries fail if a filesystem does not support this at all. By adding faked support many of these libraries become usable in combination with cloud storage with minimal effort.
I expect that after this some may want to add a more accurate mapping of the attributes.
Fixes #1062 ☕️