Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: allowlist to include module-info #5600

Merged
merged 1 commit into from
Oct 31, 2022
Merged

test: allowlist to include module-info #5600

merged 1 commit into from
Oct 31, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Oct 31, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@suztomo suztomo requested a review from a team as a code owner October 31, 2022 14:46
@blakeli0 blakeli0 closed this Oct 31, 2022
@blakeli0 blakeli0 reopened this Oct 31, 2022
@blakeli0 blakeli0 added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2022
@blakeli0 blakeli0 merged commit e1306fb into googleapis:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suztomo @blakeli0 @burkedavison