Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Row Affinity app profiles #2341

Merged
merged 10 commits into from
Dec 4, 2024
+311 −1
Merged

feat: add support for Row Affinity app profiles #2341

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b18d5ca
Create of methods, add unit tests
djyau Sep 16, 2024
e3be203
Add unit tests for BigtableInstanceAdminClientTests
djyau Sep 16, 2024
8019c29
Add tests for Create and Update App Profile
djyau Sep 16, 2024
d10c5cf
Add integration test
djyau Sep 16, 2024
047b046
Rename ofWithRowAffinity to withRowAffinity
djyau Oct 1, 2024
464d1bb
Merge branch 'main' of sso://cloud-bigtable-internal/java-bigtable in…
djyau Oct 1, 2024
4f197d4
Run mvn com.coveo:fmt-maven-plugin:format
djyau Oct 11, 2024
c6f6a78
Remove extra test for cluster IDs - one is enough
djyau Oct 11, 2024
fecd6ea
Add unit test for row affinity with set of strings
djyau Oct 11, 2024
7ba35f8
Run formatter
djyau Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Remove extra test for cluster IDs - one is enough 
Change-Id: I6d8e7bd644ce2cd8f098c8ee37b4eec1a0d642e2
@djyau
djyau committed Oct 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit c6f6a7858491d00771b717c15bc41ada6ea53edd
48 changes: 0 additions & 48 deletions ...le/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClientTests.java
View file
Original file line number Diff line number Diff line change
@@ -1129,54 +1129,6 @@ public void testCreateAppProfileAddRowAffinityAddMultipleClusterIds() {
assertThat(actualResult).isEqualTo(AppProfile.fromProto(expectedResponse));
}

@Test
public void testCreateAppProfileAddRowAffinityAddMultipleClusterIdsWithList() {
// Setup
Mockito.when(mockStub.createAppProfileCallable()).thenReturn(mockCreateAppProfileCallable);

com.google.bigtable.admin.v2.CreateAppProfileRequest expectedRequest =
com.google.bigtable.admin.v2.CreateAppProfileRequest.newBuilder()
.setParent(NameUtil.formatInstanceName(PROJECT_ID, INSTANCE_ID))
.setAppProfileId(APP_PROFILE_ID)
.setAppProfile(
com.google.bigtable.admin.v2.AppProfile.newBuilder()
.setDescription("my description")
.setMultiClusterRoutingUseAny(
com.google.bigtable.admin.v2.AppProfile.MultiClusterRoutingUseAny
.newBuilder()
.addAllClusterIds(ImmutableList.of("cluster-id-1", "cluster-id-2"))
.setRowAffinity(
com.google.bigtable.admin.v2.AppProfile.MultiClusterRoutingUseAny
.RowAffinity.getDefaultInstance())))
.build();

com.google.bigtable.admin.v2.AppProfile expectedResponse =
com.google.bigtable.admin.v2.AppProfile.newBuilder()
.setName(APP_PROFILE_NAME)
.setDescription("my description")
.setMultiClusterRoutingUseAny(
com.google.bigtable.admin.v2.AppProfile.MultiClusterRoutingUseAny.newBuilder()
.addAllClusterIds(ImmutableList.of("cluster-id-1", "cluster-id-2"))
.setRowAffinity(
com.google.bigtable.admin.v2.AppProfile.MultiClusterRoutingUseAny
.RowAffinity.getDefaultInstance()))
.build();

Mockito.when(mockCreateAppProfileCallable.futureCall(expectedRequest))
.thenReturn(ApiFutures.immediateFuture(expectedResponse));

// Execute
AppProfile actualResult =
adminClient.createAppProfile(
CreateAppProfileRequest.of(INSTANCE_ID, APP_PROFILE_ID)
.setDescription("my description")
.setRoutingPolicy(
MultiClusterRoutingPolicy.withRowAffinity("cluster-id-1", "cluster-id-2")));

// Verify
assertThat(actualResult).isEqualTo(AppProfile.fromProto(expectedResponse));
}

@Test
public void testGetAppProfile() {
// Setup