Skip to content

Commit

Permalink
docs: updated comments to match API behaviors
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 449874412
  • Loading branch information
Google APIs authored and copybara-github committed May 20, 2022
1 parent 6b3b071 commit 4c6f583
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 59 deletions.
1 change: 0 additions & 1 deletion .github/mistaken-pull-closer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
filters:
# Don't close PRs in the pubsub_dev branch.
- '@.pull_request.base.ref != "pubsub_dev"'
- '@.pull_request.base.ref != "diregapic"'

# The message to post to the closed PR.
commentBody: |
Expand Down
50 changes: 0 additions & 50 deletions .github/workflows/diregapic.yaml

This file was deleted.

5 changes: 2 additions & 3 deletions google/cloud/video/livestream/v1/outputs.proto
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2021 Google LLC
// Copyright 2022 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -16,7 +16,6 @@ syntax = "proto3";

package google.cloud.video.livestream.v1;

import "google/api/annotations.proto";
import "google/api/field_behavior.proto";
import "google/protobuf/duration.proto";

Expand Down Expand Up @@ -106,7 +105,7 @@ message Manifest {
// Maximum number of segments that this manifest holds. Once the manifest
// reaches this maximum number of segments, whenever a new segment is added to
// the manifest, the oldest segment will be removed from the manifest.
// The minimum value is 1 and the default value is 5.
// The minimum value is 3 and the default value is 5.
int32 max_segment_count = 4;

// How long to keep a segment on the output Google Cloud Storage bucket after
Expand Down
10 changes: 6 additions & 4 deletions google/cloud/video/livestream/v1/resources.proto
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2021 Google LLC
// Copyright 2022 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -16,7 +16,6 @@ syntax = "proto3";

package google.cloud.video.livestream.v1;

import "google/api/annotations.proto";
import "google/api/field_behavior.proto";
import "google/api/resource.proto";
import "google/cloud/video/livestream/v1/outputs.proto";
Expand Down Expand Up @@ -143,8 +142,7 @@ message Channel {
// specified output location.
STREAMING = 1;

// Channel is waiting for the input stream through the input. Live streams
// do not start yet.
// Channel is waiting for the input stream through the input.
AWAITING_INPUT = 2;

// Channel is running, but has trouble publishing the live streams onto the
Expand All @@ -154,6 +152,7 @@ message Channel {

// Channel is generating live streams with no input stream. Live streams are
// filled out with black screen, while input stream is missing.
// Not supported yet.
STREAMING_NO_INPUT = 5;

// Channel is stopped, finishing live streams.
Expand Down Expand Up @@ -366,6 +365,9 @@ message Event {

// Event has been created but not scheduled yet.
PENDING = 5;

// Event was stopped before running for its full duration.
STOPPED = 6;
}

// The resource name of the event, in the form of:
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/video/livestream/v1/service.proto
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2021 Google LLC
// Copyright 2022 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down

0 comments on commit 4c6f583

Please sign in to comment.