This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
feat: Integrate latest compute API definitions (2021-10-04) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first ESF (non-legacy) compute API in this repository. This change also depends on updated converter, which sorts all elemetns of the generated proto file alphabetically (in each section separately: messages, services, methods within services etc).
vchudnov-g
reviewed
Nov 2, 2021
|
@vchudnov-g updating small won't change anything except me potentially breaking it. I simply don't think it is worth it. small file exists to have a small client not to test converter itself. Also, once we are done with diregapic lro I think compute small can/should go away. |
|
It'd be nice (arguably) if the order of elements present in the small json reflected the order in which they appear in the large json.....but you're right, it shouldn't be a blocker. I'm not sure the smalls should go away eventually: they are very helpful for debugging and development, since the real files are huge.... |
vchudnov-g
approved these changes
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first ESF (non-legacy) compute API in this repository. This change also depends on updated converter, which sorts all elemetns of the generated proto file alphabetically (in each section separately: messages, services, methods within services etc).
compute.small.json is kept intact for readability (esf ordering of things is much messier).