Library now requires requests >= 2.18.0

[nkeriks]

Hi - this recent change uses the requests.models.Response object as a context manager, which is only added in recent versions (>= 2.18.0) of the requests library

While this is a year old version of requests, it would be good to have this requirement made explicit. Notably conda still packages requests 2.14.2 only.

[dhermes]

@nkeriks Thanks for bringing this up, we've had similar issues in google-cloud-python. Note that this library does not have requests as an explicit requirement.

@jonparrott WDYT is the right move here?

[theacodes]

Add an optional with requests >= 2.18.0?

[dhermes]

@jonparrott Will that enforce the lower bound when users just pip install google-resumable-media without the extras.

It's probably worth asking @nkeriks how he came about this realization.

[nkeriks]

I had an initialization script that was pip installing various packages (including google cloud python libraries) into a conda python environment. Not the greatest idea in general, but this usually handles dependencies fine.

[theacodes]

No

…

On Fri, Aug 11, 2017, 4:31 PM Danny Hermes ***@***.***> wrote: @jonparrott <https://github.com/jonparrott> Will that enforce the lower bound when users just pip install google-resumable-media without the extras. It's probably worth asking @nkeriks <https://github.com/nkeriks> how he came about this realization. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc2XGbSjJXoOmrLUPD3svyJhcjLLLks5sXORlgaJpZM4O1N8p> .

[dhermes]

@nkeriks Ahh that makes sense, thanks for the info. FWIW google-cloud-storage==1.3.1 (currently the latest) depends on requests (>=2.0.0) however the next google-cloud-python releases will have this lower bound set:

$ git log -1 --pretty=%H
cd3a05d1d6f27daf1dedf2425310e9f60dbd06b4
$ git grep -n requests -- '*setup.py'
bigquery/setup.py:57:    'requests >= 2.18.0',
core/setup.py:57:    'requests >= 2.18.0, < 3.0.0dev',
storage/setup.py:57:    'requests >= 2.18.0',

[lukesneeringer]

The optional as well as the fix in google-cloud-python should be sufficient.