Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: checkstyle-test profile name change #1144

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 28, 2025

Renaming the recently added "checkstyle" profile to "checkstyle-tests". This profile name matches java-shared-config
https://github.com/googleapis/java-shared-config/blob/2322b789d9568a1cd8ce4efc04fa11d7ff51c178/java-shared-config/pom.xml#L505C11-L505C27 and we can control the plugin invocation in the same Maven command parameter (-P=-checkstyle-test)

@suztomo suztomo requested review from a team as code owners January 28, 2025 16:21
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 28, 2025
@suztomo suztomo merged commit 91d8947 into googleapis:main Jan 30, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants