Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSV mime type #2286

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Update CSV mime type #2286

merged 1 commit into from
Aug 14, 2018

Conversation

blowmage
Copy link
Contributor

The mime-types 3.2.0 gem has changed the type for .csv files. This is needed to get the builds passing again.

@blowmage
Update CSV mime type
9d70dbe 
The mime-types 3.2.0 gem has changed the type for .csv files.
@blowmage blowmage added api: bigquery Issues related to the BigQuery API. type: cleanup An internal cleanup or hygiene concern. labels Aug 14, 2018
@blowmage blowmage self-assigned this Aug 14, 2018
@blowmage blowmage requested a review from quartzmo August 14, 2018 16:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2018
@quartzmo
Copy link
Member

Is this the correct changelog entry for mime-types 3.2.0? I don't see the change listed there.

@blowmage
Copy link
Contributor Author

Yes, that is the correct changelog entry. See the issue the changelog references, it describes the change using the CSV mime types.

mime-types/ruby-mime-types#132

One such example are "text/comma-separated-values" and "text/csv" MIME types. The former is obsolete and unregistered, while the latter is not obsolete and registered, but mime-types would still rank "text/comma-separated-values" higher because it just looks at the alphabetic order.

quartzmo
quartzmo approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed locally that these 9 tests are failing and should be resolved by this PR.

@blowmage blowmage merged commit 7adc8d2 into googleapis:master Aug 14, 2018
@quartzmo quartzmo mentioned this pull request Aug 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees

@blowmage blowmage

Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blowmage @quartzmo @googlebot