Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BucketPolicyOnly: fix broken requests to update BPO enabled field. #3781

Closed
frankyn opened this issue Aug 12, 2019 · 4 comments · Fixed by #3794
Closed

BucketPolicyOnly: fix broken requests to update BPO enabled field. #3781

frankyn opened this issue Aug 12, 2019 · 4 comments · Fixed by #3794
Assignees
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@frankyn
Copy link
Contributor

frankyn commented Aug 12, 2019

Hi @quartzmo,

Last week, a system test was skipped due to a backend bug (#3772) . The backend bug will take another 3 weeks based on my last conversation with the GCS team.

In the mean time a workaround should be put in place to reduce impact on users.
When performing an update on the BPO field (enable or disable), the UniformBucketLevelAccess field must be set to the same value as the BPO field during an Update or Patch request.

Here's an example patch:
PATCH uri
Body:

{
"iamConfiguration":
  {
     "bucketPolicyOnly": {"enabled": true},
     "uniformBucketLevelAccess": {"enabled": true}
  }
}

Related issue in Python: googleapis/google-cloud-python#8552

@frankyn frankyn changed the title BucketPolicyOnly: broken requests made to update BPO flag. BucketPolicyOnly: fix broken requests to update BPO enabled field. Aug 12, 2019
@quartzmo quartzmo self-assigned this Aug 12, 2019
@quartzmo quartzmo added api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 12, 2019
@quartzmo
Copy link
Member

Thanks @frankyn, will do!

@quartzmo
Copy link
Member

@frankyn When BucketPolicyOnly#locked_time is set, should it be set to the same value in UniformBucketLevelAccess?

@frankyn
Copy link
Contributor Author

frankyn commented Aug 15, 2019

locked_time is defined by the service and is not a user mutable field.

@quartzmo
Copy link
Member

Ah sorry to bother you, I just realized that too.

@frankyn
Copy link
Contributor Author

frankyn commented Aug 15, 2019

Not a problem, thanks for asking. Thanks for taking a look at this @quartzmo.

quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Aug 15, 2019
* Set UniformBucketLevelAccess to same value as BucketPolicyOnly

[closes googleapis#3781]
quartzmo added a commit that referenced this issue Aug 15, 2019
* Set UniformBucketLevelAccess to same value as BucketPolicyOnly

[closes #3781]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants