Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api_core): finalize during close of 'ResumableBidiRpc'. #9337

Merged
merged 3 commits into from
Oct 2, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Skip coverage for logging the nosferatu thread.
  • Loading branch information
tseaver committed Oct 1, 2019
commit 3a05c19c368b8ecfc795913b339e5bd40d327d3a
2 changes: 1 addition & 1 deletion api_core/google/api_core/bidi.py
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ def stop(self):
# The daemonized thread may itself block, so don't wait
# for it longer than a second.
self._thread.join(1.0)
if self._thread.is_alive():
if self._thread.is_alive(): # pragma: NO COVER
_LOGGER.warning("Background thread did not exit.")

self._thread = None
Expand Down