Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dlp): fix potentially unsent env variable and enable skipped tests #9300

Closed
wants to merge 15 commits into from
Closed

test(dlp): fix potentially unsent env variable and enable skipped tests #9300

wants to merge 15 commits into from

Conversation

maximus12793
Copy link
Contributor

DO NOT SUBMIT

maximus12793 and others added 5 commits September 25, 2019 22:01
@maximus12793
test(dlp): fix potentially unsent env variable and enable skipped tests.
035f9c7 
Tests can potentially break if GOOGLE_CLOUD_TESTS_IN_VPCSC is false.
Additionally, we want to enable previously skipped tests to ensure all
VPC checks are working for list tests.
@maximus12793
Remove list skips
5ace257
@maximus12793
test(dlp): fix potentially unsent env variable and enable skipped tests.
e5f124a 
Tests can potentially break if GOOGLE_CLOUD_TESTS_IN_VPCSC is false.
Additionally, we want to enable previously skipped tests to ensure all
VPC checks are working for list tests.
@maximus12793
test(dlp): fix potentially unsent env variable and enable skipped tests.
9ee1dd4 
Tests can potentially break if GOOGLE_CLOUD_TESTS_IN_VPCSC is false.
Additionally, we want to enable previously skipped tests to ensure all
VPC checks are working for list tests.
@maximus12793
Merge branch 'master' of github.com:maximus12793/google-cloud-python
6d4c4ff
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2019
@maximus12793 maximus12793 changed the title test(dlp): fix potentially unsent env variable and enable skipped tests. test(dlp): fix potentially unsent env variable and enable skipped tests Sep 25, 2019
@crwilcox crwilcox added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2019
@tseaver
Copy link
Contributor

tseaver commented Nov 13, 2019

Superseded by #9608.

@tseaver tseaver closed this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximus12793 @tseaver @crwilcox @googlebot