-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(bigquery): update existing code samples #9212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering - what's with all the dots at the end of one-line comments, e.g. # API request.
?
It seems a bit unusual (to me at lest), but nothing significant.
Anyhow, the changes look good to me all in all.
The dots are probably because our internal samples style requires that all comments be complete sentences, with capital letters and punctuation. Accordingly, these comments should be changed to "Make an API request." or "The following function makes an API request." |
@emar-kar I presume you just rebased, correct, no other changes? If this was to fix the commit message lint check, I changed the PR title to make the bot happy. We can merge the PR once the tests pass again. |
@plamut yeah, I changed the comment lines and got this confusing error. New day = new features. Just read all about it. Thank you! |
The Recommender failure is probably flakiness, I saw it on one of the other PRs, too (a re-run helped). Edit: Well, or a "permanent" issue until it gets fixed, it again failed on several PRs even after retries. |
List of changes:
API request
,Must match the destination dataset location
andWaits for the job to complete
comments.whitespaces
in prints to\t
;routine.arguments
doesn't havetype_
attribute, it was changed todata_type
..importorskip
should be assigned to its canonical name (@tswast can you confirm these imports are required).assert
.