-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt at implementing clients for Pub/Sub #910
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4bf5c05
Adding basic client class in pubsub.
dhermes 12460a9
Adding factory constructors to pubsub client.
dhermes f058b3e
Implementing Client.list_topics in pubsub.
dhermes 47cc25a
Implementing Client.list_subscriptions in pubsub.
dhermes be42839
Allowing client to be used in pubsub.Topic.
dhermes ce34ef3
Removing gcloud.pubsub.api.
dhermes e187345
Making Topic.from_api_repr accept a client.
dhermes d9e3dc3
Adding client to Subscription.from_api_repr.
dhermes 8360e69
Making client mandatory in most of pubsub.
dhermes a1a19a3
Using client on all Topic methods.
dhermes d8626ef
Using client on all Subscription methods.
dhermes ff39a92
Removing unused implict code in pubsub.
dhermes 805225b
Updating pubsub regression test for new code.
dhermes 29f35d0
Updating Pub/Sub docs based on client changes.
dhermes c206638
Addressing review comments in PR #910.
dhermes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.