-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigtable: 'test_bigtable_create_table' snippet flakes with '504 Deadline Exceeded'. #8889
Bigtable: 'test_bigtable_create_table' snippet flakes with '504 Deadline Exceeded'. #8889
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@mf2199 This PR overlaps #8879, which I reviewed today: is there a reason not to have @sangramql add this change there? |
@tseaver The other PR addresses a different (albeit similar) issue. I've asked @sangramql to review this, he will make the final call (hence the draft version). |
@googlebot I consent. |
@googlebot I consent |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Fixes #8480
We used to observe this issue while working on Bigtable. As per our understanding, this used to occur intermittently when Google Cloud takes longer than expected to create instance or table. So we added some cool down time. Now we have added a retry logic to [exponentially] factor in the cool down time, if the table creation fails. As of right now, the max retry count is 4, though it can be configured.