-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: Move maybe_fail_import() to top level test utils #8840
Conversation
FWIW, after two years, there are exactly zero uses of |
Sounds like we need to run a large-scale AdWords campaign to promote its usage. @tseaver Are you suggesting that it might be better to move this back to the |
I'm not sure. I came across it while working on googleapis/python-test-utils#43: the function has no test coverage, which meant that I had to install a development version into a virtualenv along with |
Following a recent discussion, this PR moves a test utility from BigQuery to the top-level test utils, since it is considered useful outside of BigQuery, too.
How to test
Primarily verify that the promoted utility function is general enough for the promotion.