PubSub: Remove deprecated methods and settings #8836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two have been deprecated in 0.44.0 and it's time to remove them.
tseaver
suggested changes
Jul 30, 2019
pubsub/google/cloud/pubsub_v1/subscriber/_protocol/dispatcher.py
Outdated
Show resolved
Hide resolved
pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
Outdated
Show resolved
Hide resolved
pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
Outdated
Show resolved
Hide resolved
|
The docs failure in the Pub/Sub Kokoro job looks like a transient network issue (RTD unreachable). |
45d535b to
bb9c7b7
Compare
tseaver
approved these changes
Jul 30, 2019
|
The docs build fine locally, not sure why CircleCI (still) cannot reach readthedocs. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per offline email thread, this PR removes deprecated PubSub client features (as a follow-up to #8796). It is a pre-release step for the upcoming
0.45.0release.How to test
Nothing much except for making sure that all traces of the deprecated things are indeed gone.
It is probably best to review this commit by commit.