BigQuery: Add StandardSqlDataTypes enum to BigQuery #8782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we might need to pin one of the dependencies (pyarrow?) to fix our tests. |
|
Yeah, I've already been discussing this with @tswast, it's how pyarrow (?) handles |
tswast
requested changes
Jul 25, 2019
This is a convenience enum that contains scalar SQL data types constants (a subsset of types defined in the gapic enum generated from the .proto definitions).
tswast
reviewed
Jul 26, 2019
| @@ -130,6 +131,7 @@ | |||
| "Encoding", | |||
| "QueryPriority", | |||
| "SchemaUpdateOption", | |||
| "StandardSqlDataTypes", | |||
There was a problem hiding this comment.
This reminds me: let's add an Enums section to the API reference docs, too.
https://github.com/googleapis/google-cloud-python/blob/master/bigquery/docs/reference.rst
There was a problem hiding this comment.
Added. Also had to inject an additional header line to the new enum's docstring, because Sphinx complained about a duplicate object description (took the first line - the INT64 member - which is of course directly copied from the gapic enum).
tswast
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8495.
This PR adds a convenience enum with scalar SQL data types (as per issue description).
How to test
The issue is self-explanatory. Just make sure that the enum contains all the right fields that we want in it.
Update: Additionally, make sure that the docs for the new enum are in order.