Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset: Add VPCSC tests. #8613

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Asset: Add VPCSC tests. #8613

merged 2 commits into from
Jul 8, 2019

Conversation

gaogaogiraffe
Copy link
Contributor

The tests can be run inside or outside of VPC service perimeter. The input to the script should be the following environment variables.

PROJECT_ID: a project that is inside the VPC perimeter.
GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT: a project that is outside the VPC perimeter.

The tests can be run inside or outside of VPC service perimeter. The input to the script should be the following environment variables.

PROJECT_ID: a project that is inside the VPC perimeter.
GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT: a project that is outside the VPC perimeter.
@gaogaogiraffe gaogaogiraffe requested a review from busunkim96 as a code owner July 5, 2019 23:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 5, 2019
@tseaver tseaver changed the title Add VPCSC tests for cloud asset client lib. Asset: Add VPCSC tests. Jul 8, 2019
@tseaver tseaver added api: cloudasset Issues related to the Cloud Asset Inventory API. testing labels Jul 8, 2019
@tseaver
Copy link
Contributor

tseaver commented Jul 8, 2019

The 'Datastore' failure appears to be a Kokoro-internal issue (I can't see the job / output).

@tseaver tseaver merged commit 70b4bd2 into googleapis:master Jul 8, 2019
parthea pushed a commit that referenced this pull request Oct 21, 2023
The tests can be run inside or outside of VPC service perimeter. The input to the script should be the following environment variables.

PROJECT_ID: a project that is inside the VPC perimeter.
GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT: a project that is outside the VPC perimeter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants