Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#825: Allow passing explicit connection to pubsub API methods #859

Merged
merged 9 commits into from
May 6, 2015
Merged

#825: Allow passing explicit connection to pubsub API methods #859

merged 9 commits into from
May 6, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 4, 2015

See #825.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label May 4, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b60cf16 on tseaver:825-pubsub-explicit_connection into 8b5c5b9 on GoogleCloudPlatform:master.

@tseaver tseaver mentioned this pull request May 4, 2015
Closed
@dhermes
Copy link
Contributor

dhermes commented May 6, 2015

Overall no complaints, but we still have connection bound to our objects. What is the point of #825 without the context of #728 (or something like #728 for pubsub)?

tseaver added 2 commits May 6, 2015 10:06
@tseaver
Add helper for pubsub.
d6edeb2
@tseaver
Expunge 'Topic.connection' property.
ad82cf7 
Adopt '_require_connection' pattern from storage.

Addresses:
#859 (comment)
@tseaver
Copy link
Contributor Author

tseaver commented May 6, 2015

@dhermes ad82cf7 removes all use of a .connection attribute / property in pubsub.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ad82cf7 on tseaver:825-pubsub-explicit_connection into 8b5c5b9 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented May 6, 2015

LGTM

tseaver added a commit that referenced this pull request May 6, 2015
@tseaver
Merge pull request #859 from tseaver/825-pubsub-explicit_connection
aafcd2a 
#825: Allow passing explicit connection to pubsub API methods
@tseaver tseaver merged commit aafcd2a into googleapis:master May 6, 2015
@tseaver tseaver deleted the 825-pubsub-explicit_connection branch May 6, 2015 20:50
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @coveralls @dhermes @googlebot