Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: add 'Bucket.location_type' property. #8089

Merged
merged 5 commits into from
Jul 2, 2019
Merged

Storage: add 'Bucket.location_type' property. #8089

merged 5 commits into from
Jul 2, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 21, 2019

No description provided.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 21, 2019
@tseaver tseaver requested a review from frankyn May 21, 2019 22:33
@tseaver tseaver requested a review from crwilcox as a code owner May 21, 2019 22:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 4, 2019
@JesseLovelace JesseLovelace self-requested a review June 17, 2019 20:55
JesseLovelace
JesseLovelace reviewed Jun 17, 2019
View reviewed changes
storage/google/cloud/storage/bucket.py Outdated
See
https://cloud.google.com/storage/docs/json_api/v1/buckets#storageClass
https://cloud.google.com/storage/docs/storage-classes
"""

MULTI_REGION_LOCATION_TYPE = "MULTI_REGION"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"MULTI_REGION", "REGION", and" DUAL_REGION" were supposed to be "multi-region", "region", and "dual-region". This will be changed in the API after a rollout on June 26 and should also be reflected here.

JesseLovelace
JesseLovelace requested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@JesseLovelace JesseLovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"MULTI_REGION", "REGION", and" DUAL_REGION" were supposed to be "multi-region", "region", and "dual-region". This will be changed in the API after a rollout on June 26 and should also be reflected here.

@tseaver
Copy link
Contributor Author

tseaver commented Jun 25, 2019 •
edited
Loading

@JesseLovelace What about the other storage classes ("STANDARD", "NEARLINE", "COLDLINE", "DURABLE_REDUCED_AVAILABILITY")? Or does that change only matter for the location type names?

@tseaver tseaver requested a review from tswast as a code owner June 25, 2019 21:39
@tseaver tseaver requested a review from a team June 25, 2019 21:39
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 25, 2019
tseaver added 5 commits June 26, 2019 13:31
@tseaver
Expand tests for 'Bucket' ctor.
d1a3a4a
@tseaver
Add named constants for allowed 'storage_class' values.
81aa0e5 
Un-deprecate STANDARD storage class.

Docs-deprecate storage classes implying location type.
@tseaver
Add 'Bucket.location_type' property.
8094106 
Include named constants for allowed 'location_type' values.
@tseaver
Lint.
55c94f5
@tseaver
Use mandated spellings for location type values.
2b8c62d 
Addresses:
#8089 (comment)
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 26, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Jun 26, 2019

@crwilcox I mistakenly rebased against master, rather than the target feature branch.

@tseaver
Copy link
Contributor Author

tseaver commented Jun 26, 2019

ContainerAnalysis and Grafeas failures are due to a Kokoro-internal glitch.

@tseaver
Copy link
Contributor Author

tseaver commented Jun 26, 2019

@JesseLovelace PTAL.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 2, 2019

@JesseLovelace I'm going to merge this PR into the storage-location_type-feature branch.

@frankyn Please let me know when we are ready to merge that branch to master.

@tseaver tseaver merged commit 0d8d6dc into googleapis:storage-location_type-feature Jul 2, 2019
@tseaver tseaver deleted the storage-add-bucket-location_type branch July 2, 2019 19:03
tseaver added a commit that referenced this pull request Jul 2, 2019
@tseaver
Add 'Bucket.location_type' property. (#8089)
97b9cd2 
- Add named constants for allowed 'storage_class' values.
- Un-deprecate STANDARD storage class.
- Docs-deprecate storage classes implying location type.
- Add 'Bucket.location_type' property.
- Add named constants for allowed 'location_type' values.
tseaver added a commit that referenced this pull request Jul 2, 2019
@tseaver
Add 'Bucket.location_type' property. (#8089)
c43b7e7 
- Add named constants for allowed 'storage_class' values.
- Un-deprecate STANDARD storage class.
- Docs-deprecate storage classes implying location type.
- Add 'Bucket.location_type' property.
- Add named constants for allowed 'location_type' values.
JesseLovelace
JesseLovelace reviewed Jul 2, 2019
View reviewed changes
storage/google/cloud/storage/bucket.py
"NEARLINE",
"COLDLINE",
"STANDARD", # alias for MULTI_REGIONAL/REGIONAL, based on location
"DURABLE_REDUCED_AVAILABILITY", # deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is renaming these a breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't any renaming happening, just naming: the existing code used string literals, while the PR adds named constants for them.

tseaver added a commit that referenced this pull request Jul 9, 2019
@tseaver
Add 'Bucket.location_type' property. (#8089)
9a618af 
- Add named constants for allowed 'storage_class' values.
- Un-deprecate STANDARD storage class.
- Docs-deprecate storage classes implying location type.
- Add 'Bucket.location_type' property.
- Add named constants for allowed 'location_type' values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseLovelace JesseLovelace JesseLovelace requested changes

@frankyn frankyn Awaiting requested review from frankyn

@crwilcox crwilcox Awaiting requested review from crwilcox

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @googlebot @JesseLovelace @yoshi-automation