Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phishing Protection: Finish initial library setup. #7865

Closed
wants to merge 5 commits into from
Closed

Phishing Protection: Finish initial library setup. #7865

wants to merge 5 commits into from

Conversation

busunkim96
Copy link
Contributor

The previous generation had several steps missing, and that release ended up failing. This finishes out the setup.

  • Rename of package from google-cloud-phishingprotection to google-cloud-phishing-protectionwith a replace in synth.py.
  • Complete docs setup.
  • Exclude un-executed line in types.py so unit tests do not fail.
  • Fix classifier in setup.py.

@busunkim96 busunkim96 requested a review from tseaver May 6, 2019 23:18
@busunkim96 busunkim96 requested a review from crwilcox as a code owner May 6, 2019 23:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2019
@busunkim96 busunkim96 added the api: phishingprotection Issues related to the Phishing Protection API. label May 6, 2019
@busunkim96 busunkim96 force-pushed the phishing-protection-fix branch from 418949f to 6d3ecd3 Compare May 6, 2019 23:23
@tseaver
Copy link
Contributor

tseaver commented May 7, 2019

@busunkim96 In addition to renaming the distutils project, do we want to rename the phishingprotection directory to phishing_protection?

@busunkim96 busunkim96 mentioned this pull request May 8, 2019
Merged
@busunkim96 busunkim96 force-pushed the phishing-protection-fix branch from e83c78f to 9f0736e Compare May 9, 2019 22:45
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 13, 2019
@busunkim96 busunkim96 mentioned this pull request May 14, 2019
Closed
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@busunkim96 busunkim96 closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: phishingprotection Issues related to the Phishing Protection API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@busunkim96 @tseaver @googlebot @yoshi-automation @yoshi-kokoro