Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swapping the order of kind and dataset_id in Query constructor. #718

Merged
merged 1 commit into from
Mar 12, 2015
Merged

Swapping the order of kind and dataset_id in Query constructor. #718

merged 1 commit into from
Mar 12, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 12, 2015

Also updating docstring in Query.fetch() to reflect this.

Partially addresses #704.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2015
@dhermes dhermes force-pushed the change-query-argument-order branch from e7b3e23 to 5fd4656 Compare March 12, 2015 19:24
@dhermes dhermes mentioned this pull request Mar 12, 2015
Closed
tseaver
tseaver reviewed Mar 12, 2015
View reviewed changes
gcloud/datastore/query.py
:type dataset_id: string
:param dataset_id: The ID of the dataset to query. If not passed,
uses the implicit default.

:type kind: string
:param kind: The kind to query.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Mar 12, 2015

LGTM, modulo the datastore. prefix notation issues I expressed earlier.

@dhermes
Swapping the order of kind and dataset_id in Query constructor.
749712e 
Also updating docstring in Query.fetch() to reflect this.

Partially addresses googleapis#704.
@dhermes dhermes force-pushed the change-query-argument-order branch from 5fd4656 to 749712e Compare March 12, 2015 19:46
@dhermes
Copy link
Contributor Author

dhermes commented Mar 12, 2015

Rebased on top of HEAD / swapped the docstring args back to the rightful position.

Will wait on Travis before merging. Boo to slow Travis. It seems they went from no outages to weekly outages in the recent past.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 749712e on dhermes:change-query-argument-order into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 749712e on dhermes:change-query-argument-order into * on GoogleCloudPlatform:master*.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 12, 2015

Merging. Coveralls decided not to send the message but it says 100%:
https://coveralls.io/builds/2102263

UPDATE: Coveralls literally sent the go-ahead as I clicked "Comment". Amazing!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 749712e on dhermes:change-query-argument-order into 3b65abd on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Mar 12, 2015
@dhermes
Merge pull request #718 from dhermes/change-query-argument-order
d9e2156 
Swapping the order of kind and dataset_id in Query constructor.
@dhermes dhermes merged commit d9e2156 into googleapis:master Mar 12, 2015
@dhermes dhermes deleted the change-query-argument-order branch March 12, 2015 20:23
@dhermes dhermes mentioned this pull request Mar 12, 2015
Merged
parthea pushed a commit that referenced this pull request Jul 6, 2023
@dpebot @busunkim96
Auto-update dependencies. [(#718)](GoogleCloudPlatform/python-docs-sa…
f2495ec 
…mples#718)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @coveralls @googlebot