Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy to open a documentation bug from the docs themselves #680

Merged
merged 4 commits into from
Feb 25, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 25, 2015

Fixes #98.

A typical "Report an Issue" button will link to:
https://github.com/GoogleCloudPlatform/gcloud-python/issues/new?title=%5BDocumentation+Issue%5D+&body=Page+Name%3A+datastore-api%0ARelease%3A%200.4.1

The release in the link will either be a stable release (as in http://googlecloudplatform.github.io/gcloud-python/0.4.1/index.html) or will be a commit hash (as in http://googlecloudplatform.github.io/gcloud-python/master/)

(The "release" may need some URL escaping.)

- Anchored as part of <header class="page-header fixed">
- Still needs work for responsive parts (small page sizes)
- Link has a template with information about the page the
  issue is filed from

Fixes googleapis#98.
Responsive CSS reduces the amount of horizontal items at
50em (800px) so we hide the anchored button and reveal one
at the top next to "Version History".
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2015
@dhermes dhermes added the docs label Feb 25, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Feb 25, 2015

I took a stab at handling the media queries for devices with not-so-wide screens.

Under 50em we have:
screen_shot_072
and above (hopefully the default experience for people actively coding) we have:
screen_shot_073

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0f237b9 on dhermes:fix-98 into 0e41dc3 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d95dd47 on dhermes:fix-98 into 0e41dc3 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Feb 25, 2015

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Feb 25, 2015

https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/52161440 (build 1192) has finished but still shows as pending due to https://twitter.com/traviscistatus/status/570637064019914752

Going to merge this now

dhermes added a commit that referenced this pull request Feb 25, 2015
Make it easy to open a documentation bug from the docs themselves
@dhermes dhermes merged commit 958b6cb into googleapis:master Feb 25, 2015
@dhermes dhermes deleted the fix-98 branch February 25, 2015 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easy to open a documentation bug from the docs themselves
4 participants