Unwinding cases in Test_set_default_dataset_id and having better test separation #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +86,16 @@ def compute_engine_id(): | |||
| connection.close() | |||
|
|
|||
|
|
|||
| def _get_production_dataset_id(): | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also defining one-liner _get_production_dataset_id() and _get_gcd_dataset_id() methods to mirror the app_engine_id() and compute_engine_id() methods in _implicit_environ.
Also fixing unused dataset_id=None in _callFUT in Test__get_gcd_dataset_id and Test__get_gcd_dataset_id.
Also adding the relative ordering parts to Test__determine_default_dataset_id. Tests previously were mixing the logic of the 4 possible environments while the simple ordering of them in set_default_dataset_id() and now _determine_default_dataset_id(). This separates that logic and makes sure each environ helper is called in a specific order.
a09391e to
1dd6709
Compare
|
@tseaver Issues remaining? |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Feb 26, 2015
Unwinding cases in Test_set_default_dataset_id and having better test separation
|
Let's see if Travis is all the way back on track... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Has #668 as diffbase
Tests previously were mixing the logic of the 4 possible environments while the simple ordering of them in
set_default_dataset_id()and now_determine_default_dataset_id().This PR separates that logic and makes sure each environ helper is called in a specific order.
In order to do this it also introduces two one-line functions
_get_production_dataset_id()and_get_gcd_dataset_id()in the implicit environ module.