Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving set_default_dataset_id into _implicit_environ. #666

Merged
merged 1 commit into from
Feb 19, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 19, 2015

NOTE: Has #665 as a diffbase

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 15db084 on dhermes:lazy-loading-attempt-3 into 72b6359 on GoogleCloudPlatform:master.

@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Feb 19, 2015
@dhermes dhermes mentioned this pull request Feb 19, 2015
@tseaver
Copy link
Contributor

tseaver commented Feb 19, 2015

15db084 LGTM

@dhermes dhermes force-pushed the lazy-loading-attempt-3 branch from 15db084 to 7d75636 Compare February 19, 2015 19:36
@dhermes
Copy link
Contributor Author

dhermes commented Feb 19, 2015

Rebased on top of #665. Had to sniff out the redundant tests since the test moved wholesale.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7d75636 on dhermes:lazy-loading-attempt-3 into 6ff634a on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Feb 19, 2015
Moving set_default_dataset_id into _implicit_environ.
@dhermes dhermes merged commit 26dba83 into googleapis:master Feb 19, 2015
@dhermes dhermes deleted the lazy-loading-attempt-3 branch February 19, 2015 19:39
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants