Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: Error Reporting: fix client_info bug, update docstrings. #6411

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: Error Reporting: fix client_info bug, update docstrings. #6411

wants to merge 1 commit into from

Conversation

dpebot
Copy link
Contributor

@dpebot dpebot commented Nov 6, 2018

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/devtools/clouderrorreporting/artman_errorreporting.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/error-reporting-v1beta1.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/error_group_service_pb2.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/report_errors_service_pb2.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/error_group_service_pb2_grpc.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/error_stats_service_pb2_grpc.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/report_errors_service_pb2_grpc.py.
synthtool > Replaced 'from google.devtools.clouderrorreporting_v1beta1.proto import ' in google/cloud/errorreporting_v1beta1/proto/error_stats_service_pb2.py.
synthtool > Cleaned up 0 temporary directories.

@dpebot dpebot requested a review from crwilcox as a code owner November 6, 2018 13:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2018
@tseaver tseaver added codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: clouderrorreporting Issues related to the Error Reporting API. labels Nov 6, 2018
tseaver
tseaver reviewed Nov 6, 2018
View reviewed changes
error_reporting/google/cloud/errorreporting_v1beta1/gapic/report_errors_service_client.py
a ``key`` parameter. For example:

.. raw:: html

This comment was marked as spam.

Sign in to view

@tseaver tseaver changed the title [CHANGE ME] Re-generated error_reporting to pick up changes in the API or client library generator. DO NOT MERGE: Error Reporting: fix client_info bug, update docstrings. Nov 6, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 6, 2018

Includes codegen fix for #5710.

@tseaver tseaver mentioned this pull request Nov 7, 2018
Merged
@tseaver tseaver closed this in #6442 Nov 7, 2018
tseaver added a commit that referenced this pull request Nov 7, 2018
@tseaver
Fix client_info bug, update docstrings via synth. (#6442)
271f3ef 
Remove now-spurious replacements from synth.

Fix newly-generated raw HTML junk in docstrings.

Closes #6411.
@tseaver tseaver deleted the autosynth-error_reporting branch November 7, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: clouderrorreporting Issues related to the Error Reporting API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpebot @tseaver @googlebot