Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: needs update to 'vision/synth.py' #6359

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: needs update to 'vision/synth.py' #6359

wants to merge 1 commit into from

Conversation

dpebot
Copy link
Contributor

@dpebot dpebot commented Nov 1, 2018

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/vision/artman_vision_v1.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/vision-v1.
synthtool > Replaced 'from __future__ import absolute_import' in google/cloud/vision_v1/__init__.py.
synthtool > Replaced 'image_annotator_client' in google/cloud/vision_v1/__init__.py.
synthtool > Replaced 'from google.cloud.vision_v1.gapic import iac' in google/cloud/vision_v1/__init__.py.
synthtool > Replaced 'class ImageAnnotatorClient\\(iac.ImageAnnotatorClient\\):' in google/cloud/vision_v1/__init__.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1/gapic/image_annotator_client.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1/gapic/product_search_client.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1/gapic/transports/image_annotator_grpc_transport.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1/gapic/transports/product_search_grpc_transport.py.
synthtool > No replacements made in ['google/cloud/vision_v1/**/*.py', 'tests/system/gapic/v1/**/*.py'] for pattern from google.cloud.gapic.vision import enums, maybe replacement is not longer needed?
synthtool > No replacements made in tests/system/gapic/v1/**/*.py for pattern from google.cloud.gapic import vision, maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/vision_v1/**/*.py for pattern from google.cloud.gapic.vision.v1, maybe replacement is not longer needed?
synthtool > Replaced '    (- The API has a collection of ``ProductSet.*\n)\\s+(``project.*\n)\\s+(products.*)' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > No replacements made in google/cloud/vision_v1p3beta1/gapic/product_search_client.py for pattern (        \* .*
        )([^\s*]), maybe replacement is not longer needed?
synthtool > Replaced '(- Each ``Product`` has a collection .*\n.*\n)(\\s+""")' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > Running generator for google/cloud/vision/artman_vision_v1p1beta1.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/vision-v1p1beta1.
synthtool > Replaced 'from __future__ import absolute_import' in google/cloud/vision_v1p1beta1/__init__.py.
synthtool > Replaced 'image_annotator_client' in google/cloud/vision_v1p1beta1/__init__.py.
synthtool > Replaced 'from google.cloud.vision_v1p1beta1.gapic import iac' in google/cloud/vision_v1p1beta1/__init__.py.
synthtool > Replaced 'class ImageAnnotatorClient\\(iac.ImageAnnotatorClient\\):' in google/cloud/vision_v1p1beta1/__init__.py.
synthtool > No replacements made in ['google/cloud/vision_v1p1beta1/**/*.py', 'tests/system/gapic/v1p1beta1/**/*.py'] for pattern import google.api_core.operations_v1, maybe replacement is not longer needed?
synthtool > No replacements made in ['google/cloud/vision_v1p1beta1/**/*.py', 'tests/system/gapic/v1p1beta1/**/*.py'] for pattern from google.cloud.gapic.vision import enums, maybe replacement is not longer needed?
synthtool > No replacements made in tests/system/gapic/v1p1beta1/**/*.py for pattern from google.cloud.gapic import vision, maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/vision_v1p1beta1/**/*.py for pattern from google.cloud.gapic.vision.v1p1beta1, maybe replacement is not longer needed?
synthtool > Replaced '    (- The API has a collection of ``ProductSet.*\n)\\s+(``project.*\n)\\s+(products.*)' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > No replacements made in google/cloud/vision_v1p3beta1/gapic/product_search_client.py for pattern (        \* .*
        )([^\s*]), maybe replacement is not longer needed?
synthtool > Replaced '(- Each ``Product`` has a collection .*\n.*\n)(\\s+""")' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > Running generator for google/cloud/vision/artman_vision_v1p2beta1.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/vision-v1p2beta1.
synthtool > Replaced 'from __future__ import absolute_import' in google/cloud/vision_v1p2beta1/__init__.py.
synthtool > Replaced 'image_annotator_client' in google/cloud/vision_v1p2beta1/__init__.py.
synthtool > Replaced 'from google.cloud.vision_v1p2beta1.gapic import iac' in google/cloud/vision_v1p2beta1/__init__.py.
synthtool > Replaced 'class ImageAnnotatorClient\\(iac.ImageAnnotatorClient\\):' in google/cloud/vision_v1p2beta1/__init__.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1p2beta1/gapic/image_annotator_client.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1p2beta1/gapic/transports/image_annotator_grpc_transport.py.
synthtool > No replacements made in ['google/cloud/vision_v1p2beta1/**/*.py', 'tests/system/gapic/v1p2beta1/**/*.py'] for pattern from google.cloud.gapic.vision import enums, maybe replacement is not longer needed?
synthtool > No replacements made in tests/system/gapic/v1p2beta1/**/*.py for pattern from google.cloud.gapic import vision, maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/vision_v1p2beta1/**/*.py for pattern from google.cloud.gapic.vision.v1p2beta1, maybe replacement is not longer needed?
synthtool > Replaced '    (- The API has a collection of ``ProductSet.*\n)\\s+(``project.*\n)\\s+(products.*)' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > No replacements made in google/cloud/vision_v1p3beta1/gapic/product_search_client.py for pattern (        \* .*
        )([^\s*]), maybe replacement is not longer needed?
synthtool > Replaced '(- Each ``Product`` has a collection .*\n.*\n)(\\s+""")' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > Running generator for google/cloud/vision/artman_vision_v1p3beta1.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/vision-v1p3beta1.
synthtool > Replaced 'from __future__ import absolute_import' in google/cloud/vision_v1p3beta1/__init__.py.
synthtool > Replaced 'image_annotator_client' in google/cloud/vision_v1p3beta1/__init__.py.
synthtool > Replaced 'from google.cloud.vision_v1p3beta1.gapic import iac' in google/cloud/vision_v1p3beta1/__init__.py.
synthtool > Replaced 'class ImageAnnotatorClient\\(iac.ImageAnnotatorClient\\):' in google/cloud/vision_v1p3beta1/__init__.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1p3beta1/gapic/image_annotator_client.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1p3beta1/gapic/transports/image_annotator_grpc_transport.py.
synthtool > Replaced 'import google.api_core.operations_v1' in google/cloud/vision_v1p3beta1/gapic/transports/product_search_grpc_transport.py.
synthtool > No replacements made in ['google/cloud/vision_v1p3beta1/**/*.py', 'tests/system/gapic/v1p3beta1/**/*.py'] for pattern from google.cloud.gapic.vision import enums, maybe replacement is not longer needed?
synthtool > No replacements made in tests/system/gapic/v1p3beta1/**/*.py for pattern from google.cloud.gapic import vision, maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/vision_v1p3beta1/**/*.py for pattern from google.cloud.gapic.vision.v1p3beta1, maybe replacement is not longer needed?
synthtool > Replaced '    (- The API has a collection of ``ProductSet.*\n)\\s+(``project.*\n)\\s+(products.*)' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > Replaced '(        \\* .*\n        )([^\\s*])' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > Replaced '(- Each ``Product`` has a collection .*\n.*\n)(\\s+""")' in google/cloud/vision_v1p3beta1/gapic/product_search_client.py.
synthtool > Cleaned up 0 temporary directories.

@dpebot dpebot requested a review from crwilcox as a code owner November 1, 2018 12:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated vision to pick up changes in the API or client library generator. Vision: add product search support Nov 1, 2018
tseaver
tseaver previously approved these changes Nov 1, 2018
View reviewed changes
vision/google/cloud/vision_v1/gapic/image_annotator_client.py
from google.longrunning import operations_pb2
from google.protobuf import empty_pb2
from google.protobuf import field_mask_pb2

This comment was marked as spam.

Sign in to view

@tseaver tseaver added api: vision Issues related to the Cloud Vision API. codegen labels Nov 1, 2018
@tseaver tseaver dismissed their stale review November 1, 2018 14:29

Docs build broken

tseaver
tseaver suggested changes Nov 1, 2018
View reviewed changes
vision/google/cloud/vision_v1/gapic/product_search_client.py

- The API has a collection of ``ProductSet`` resources, named
``projects/*/locations/*/productSets/*``, which acts as a way to put different
products into groups to limit identification.

This comment was marked as spam.

Sign in to view

@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Nov 1, 2018
@tseaver tseaver mentioned this pull request Nov 1, 2018
Merged
@tseaver tseaver changed the title Vision: add product search support DO NOT MERGE: needs update to 'vision/synth.py' Nov 1, 2018
@tseaver tseaver closed this in #6361 Nov 1, 2018
tseaver added a commit that referenced this pull request Nov 1, 2018
@tseaver
Vision: pick up addition of 'product_search_client' to 'vision_v1' (#…
cbb1070 
…6361)

Closes #6359.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@tseaver
Vision: pick up addition of 'product_search_client' to 'vision_v1' (#…
c3ea162 
…6361)

Closes #6359.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpebot @tseaver @googlebot