Allow http as an argument to base Connection class. #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Subclasses may seek to use the private key from ``credentials`` to sign | ||
| data. | ||
|
|
||
| A custom (non-``httplib``) HTTP object must have a ``request`` method |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I don't see any harm in allowing the caller to pass in the |
This will allow libraries other than httplib2 to be used. Fixes googleapis#551.
|
@tseaver I updated to non-httplib2 (folded into 2nd commit on rebase). As for the layer, I'm unclear on who will use it but could see people building adapters that we wouldn't need to have control over. Other issues? |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Feb 12, 2015
Allow http as an argument to base Connection class.
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow libraries other than httplib2 to be used.
Fixes #551.
@tseaver I dream of tearing
httplib2out as a dependency (also would need to come out ofoauth2client) and using something simple likehttplibfor the defaulthttpobject. Sigh.But really this is to support users in specialized environments like
twistedor people who preferrequests