Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synth.py and Generate KMS v1 #5665

Merged
merged 2 commits into from
Jul 20, 2018
Merged

Conversation

crwilcox
Copy link
Contributor

No description provided.

@crwilcox crwilcox requested a review from theacodes as a code owner July 20, 2018 18:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2018
@crwilcox crwilcox requested a review from tseaver July 20, 2018 20:04
@crwilcox
Copy link
Contributor Author

This was a pretty clean generation. There was only one fix needed in synth.py

if client_info is None:
client_info = (
google.api_core.gapic_v1.client_info.DEFAULT_CLIENT_INFO)
client_info.gapic_version = _GAPIC_LIBRARY_VERSION

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@crwilcox crwilcox merged commit 3880e1f into googleapis:master Jul 20, 2018
@crwilcox crwilcox deleted the kms-generation branch July 20, 2018 21:10
parthea pushed a commit that referenced this pull request Oct 21, 2023
Initial generation of KMS v1 endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants