Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: skips pandas when running python 3.4 nox session #4681

Merged
merged 1 commit into from
Jan 2, 2018
Merged

BigQuery: skips pandas when running python 3.4 nox session #4681

merged 1 commit into from
Jan 2, 2018

Conversation

alixhami
Copy link
Contributor

@alixhami alixhami commented Jan 2, 2018

Resolves #4587

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label Jan 2, 2018
@alixhami alixhami requested a review from tseaver as a code owner January 2, 2018 16:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 2, 2018
dhermes
dhermes reviewed Jan 2, 2018
View reviewed changes
bigquery/nox.py
@@ -36,7 +36,10 @@ def default(session):
"""
# Install all test dependencies, then install this package in-place.
session.install('mock', 'pytest', 'pytest-cov', *LOCAL_DEPS)
session.install('-e', '.[pandas]')
if session.interpreter == 'python3.4':

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@alixhami alixhami mentioned this pull request Jan 2, 2018
Closed
@tswast
Copy link
Contributor

tswast commented Jan 2, 2018

CircleCI passes for BigQuery. Is failing for google.cloud.error_reporting, which I believe is unrelated.

@tswast tswast merged commit f4e029a into googleapis:master Jan 2, 2018
@dhermes
Copy link
Contributor

dhermes commented Jan 2, 2018

@tswast Definitely unrelated.

@alixhami To avoid running tests you don't care about, make sure your branch is rebased off of the latest master.

@alixhami alixhami deleted the remove-nox-3.4-pandas branch January 2, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@tswast tswast tswast approved these changes

@theacodes theacodes Awaiting requested review from theacodes

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alixhami @tswast @dhermes @googlebot